Skip to content
Commit 57fb907d authored by Emil Medve's avatar Emil Medve Committed by Joerg Roedel
Browse files

iommu/fsl: Really fix init section(s) content



'0f1fb99b iommu/fsl: Fix section mismatch' was intended to address the modpost
warning and the potential crash. Crash which is actually easy to trigger with a
'unbind' followed by a 'bind' sequence. The fix is wrong as
fsl_of_pamu_driver.driver gets added by bus_add_driver() to a couple of
klist(s) which become invalid/corrupted as soon as the init sections are freed.
Depending on when/how the init sections storage is reused various/random errors
and crashes will happen

'cd70d465 iommu/fsl: Various cleanups' contains annotations that go further down
the wrong path laid by '0f1fb99b iommu/fsl: Fix section mismatch'

Now remove all the incorrect annotations from the above mentioned patches (not
exactly a revert) and those previously existing in the code, This fixes the
modpost warning(s), the unbind/bind sequence crashes and the random
errors/crashes

Fixes: 0f1fb99b ("iommu/fsl: Fix section mismatch")
Fixes: cd70d465 ("iommu/fsl: Various cleanups")
Signed-off-by: default avatarEmil Medve <Emilian.Medve@Freescale.com>
Acked-by: default avatarVarun Sethi <Varun.Sethi@freescale.com>
Cc: stable@vger.kernel.org
Tested-by: default avatarMadalin Bucur <Madalin.Bucur@freescale.com>
Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent bc465aa9
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment