Skip to content
Commit ea1b75cf authored by Eric W. Biederman's avatar Eric W. Biederman
Browse files

signal/mips: Document a conflict with SI_USER with SIGFPE



Setting si_code to __SI_FAULT results in a userspace seeing
an si_code of 0.  This is the same si_code as SI_USER.  Posix
and common sense requires that SI_USER not be a signal specific
si_code.  As such this use of 0 for the si_code is a pretty
horribly broken ABI.

This use of of __SI_FAULT is only a decade old.  Which compared
to the other pieces of kernel code that has made this mistake
is almost yesterday.

This is probably worth fixing but I don't know mips well enough
to know what si_code to would be the proper one to use.

Cc: Ralf Baechle <ralf@linux-mips.org>
Ref: 948a34cf ("[MIPS] Maintain si_code field properly for FP exceptions")
Signed-off-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
parent cc9f72e4
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment