Skip to content
Commit c225aa57 authored by Simon Holm Thøgersen's avatar Simon Holm Thøgersen Committed by Theodore Ts'o
Browse files

ext4: fix wrong use of do_div



the following warning:

fs/jbd2/journal.c: In function ‘jbd2_seq_info_show’:
fs/jbd2/journal.c:850: warning: format ‘%lu’ expects type ‘long
unsigned int’, but argument 3 has type ‘uint32_t’

is caused by wrong usage of do_div that modifies the dividend in-place
and returns the quotient. So not only would an incorrect value be
displayed, but s->journal->j_average_commit_time would also be changed
to a wrong value!

Fix it by using div_u64 instead.

Signed-off-by: default avatarSimon Holm Thøgersen <odie@cs.aau.dk>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
parent 18e352e4
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment