Skip to content
Commit 6c8f7e70 authored by Thomas Graf's avatar Thomas Graf Committed by David S. Miller
Browse files

netlink: hold nl_sock_hash_lock during diag dump



Although RCU protection would be possible during diag dump, doing
so allows for concurrent table mutations which can render the
in-table offset between individual Netlink messages invalid and
thus cause legitimate sockets to be skipped in the dump.

Since the diag dump is relatively low volume and consistency is
more important than performance, the table mutex is held during
dump.

Reported-by: default avatarAndrey Wagin <avagin@gmail.com>
Signed-off-by: default avatarThomas Graf <tgraf@suug.ch>
Fixes: e341694e ("netlink: Convert netlink_lookup() to use RCU protected hash table")
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9ea88a15
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment