Skip to content
Commit c241580d authored by Hongwei Wang's avatar Hongwei Wang
Browse files

Fixes autoEnterPip transition from landscape

Fixes included in this change
- PiP bounces back to fullscreen. The animation direction is not cleaned
  up after animation finishes and when display rotation callback
  happens and calls into PipTaskOrganizer#onMovementBoundsChanged, it
  accidentally invokes the onTaskVanished. Therefore, this does not
  happen on the first try but following attempts.
- PiP window offsets to the bottom caused by duplicated display changed
  callbacks, bail early if we know for sure the DisplayLayout objects
  are identical. Also, when display rotation callback happens, the
  PipBoundsState#getNormalBounds is still in landscape though the
  internal rotation has been set in PipController#startSwipePipToHome.

Known issue
- PiP window flickers at the end of the transition, will track in
  different bug.

Video: http://rcll/aaaaaabFQoRHlzixHdtY/hAdwMhKMaYTylRcnW24Utg
Bug: 179721427
Bug: 179718773
Test: repeatedly enter PiP from landscape with autoEnterPip, see video
Change-Id: I77c6f441563bc54720b9ef2952526691c495a777
parent c952ffe7
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment