Skip to content
Commit e466446b authored by François Degros's avatar François Degros Committed by Copybara-Service
Browse files

[zip] Improve log messages

Removed option UnzipOptions::log_skipped_files. It wasn't getting set
anywhere. Instead, changed the "skipped entry" log level to VLOG(1).

Improved log messages. Redacted file paths that could be considered PII
in some circumstances.

Changed some debug warning messages to error messages.

BUG=chromium:1303983
TEST=autoninja -C out/Default zlib_unittests && out/Default/zlib_unittests
TEST=autoninja -C out/Default components_unittests && out/Default/components_unittests --gtest_filter='UnzipTest.*'

Change-Id: I2bc5fc7d3dcf5af465faee4bdd4311e244486a9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3520763


Reviewed-by: default avatarAlex Danilo <adanilo@chromium.org>
Commit-Queue: François Degros <fdegros@chromium.org>
Cr-Commit-Position: refs/heads/main@{#980441}
NOKEYCHECK=True
GitOrigin-RevId: f2cb378ae18451b14f0176de16fe4745aead0a9f
parent c0f60596
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment