Skip to content
Commit d689fca5 authored by Peter Collingbourne's avatar Peter Collingbourne Committed by Copybara-Service
Browse files

[zlib] Fix infinite loop in CRC32 intrinsics.

When building zlib with CRC enabled, such as with -march=armv8.3a,
arm_acle.h will define functions named e.g. __crc32d that calls
__builtin_arm_crc32d. However, with our macro definitions we will end
up causing the header to define functions named __builtin_arm_crc32*
that call themselves, creating an infinite loop when the intrinsic
is called. Prevent this by moving the macro definitions to after the
header inclusion.

Bug: angleproject:7722
Change-Id: I1bbc26cfb241a147a777a914c966351291f56db6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3933186


Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Auto-Submit: Peter Collingbourne <pcc@chromium.org>
Reviewed-by: default avatarAdenilson Cavalcanti <cavalcantii@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1054394}
NOKEYCHECK=True
GitOrigin-RevId: f9a8b512a90f410bb9302a3137855fb688316d3d
parent 6fe4ce82
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment