Skip to content
Commit 90769c8b authored by luci-bisection@appspot.gserviceaccount.com's avatar luci-bisection@appspot.gserviceaccount.com Committed by Copybara-Service
Browse files

Revert "[zlib] Enable LIT_MEM code path"

This reverts commit 0f445392841590a53180bf4c4e9a9d9b9d627c6a.

Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5720452297129984

Sample build with failed test: https://ci.chromium.org/b/8761782068246968417
Affected test(s):
[ninja://third_party/zlib:zlib_unittests/ZlibTest.DeflateZFixedCorruption](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fthird_party%2Fzlib:zlib_unittests%2FZlibTest.DeflateZFixedCorruption?q=VHash%3Af3b20d64c227e090)

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5720452297129984&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5078349&type=BUG

Original change's description:
> [zlib] Enable LIT_MEM code path
>
> Introduced on zlib 1.3.0.1, this will allow a small compression
> speed improvement at cost of using a bit more memory.
>
> Observed average gain was 2.6% (SPR) and 2.3% (M1).
>
> It is interesting that it will have a bigger impact on files with higher entropy like JPG (+5.3%) and pre-compressed (baddata +7%), probably because those are cases where more literals are produced by the encoder since it is harder to find matches in LZ77 for such inputs.
>
> Bug: 1447443
> Change-Id: I09f15c8bd0f400d5485a10aa38bdc2dd1ece2449
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5078349


> Reviewed-by: default avatarHans Wennborg <hans@chromium.org>
> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1237242}
>

Bug: 1447443
Change-Id: I368496637fcb1729c47a7f32c46fded0395c398b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5120768


Owners-Override: Ming-Ying Chung <mych@chromium.org>
Reviewed-by: default avatarMing-Ying Chung <mych@chromium.org>
Commit-Queue: Ming-Ying Chung <mych@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1237342}
NOKEYCHECK=True
GitOrigin-RevId: 2422761ea019c6181def8ad465a7b115a0324626
parent 38c8e309
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment