Skip to content
Commit 23dbc912 authored by robert.bradford's avatar robert.bradford Committed by Commit bot
Browse files

Revert of Integrate SIMD optimisations for zlib (patchset #14 id:280001 of...

Revert of Integrate SIMD optimisations for zlib (patchset #14 id:280001 of https://codereview.chromium.org/552123005/)

Reason for revert:
Strong candidate for: multiple Linux MSan test failures with:

SUMMARY: MemorySanitizer: use-of-uninitialized-value ??:0 ??

Including: CompressionUtilsTest.GzipCompression

Original issue's description:
> Integrate SIMD optimisations for zlib
>
> These optimisations have been published on zlib mailing list and at
> https://github.com/jtkukunas/zlib/
>
> This change merges the following optimisation patches:
> - "For x86, add CPUID check."
> - "Adds SSE2 optimized hash shifting to fill_window."
> - "add SSE4.2 optimized hash function"
> - "add PCLMULQDQ optimized CRC folding"
>
> From Jim Kukunas <james.t.kukunas@linux.intel.com> and adapts them to the
> current zlib version in Chromium.
>
> The optimisations are enabled at runtime if all the necessary CPU features are
> present. As the optimisations require extra cflags to enable the compiler to
> use the instructions the optimisations are held in their own static library
> with a stub implementation to allow linking on other platforms.
>
> TEST=net_unittests(GZipUnitTest) passes, Chrome functions and performance
> improvement seen on RoboHornet benchmark on Linux Desktop
> BUG=401517
>
> Committed: https://crrev.com/e045ec106de29562ae94eafccde49a7b73848471
> Cr-Commit-Position: refs/heads/master@{#300866}

TBR=agl@chromium.org,nathan.d.ciobanu@intel.com
NOTREECHECKS=true
NOTRY=true
BUG=401517

Review URL: https://codereview.chromium.org/671163003

Cr-Original-Commit-Position: refs/heads/master@{#300889}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ca54b3014721cdc27e4a17dd2c82fe5811fa39cc
parent 02acec91
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment