Skip to content
Commit c9be3f36 authored by Hongwei Wang's avatar Hongwei Wang
Browse files

Add separated Pip1 and Pip2 dagger module

- Moved all legacy PiP related to its own Pip1Module and
  Pip1SharedModule (shared with TvPipModule)
- Added a placeholder Pip2Module
- Hold all PiP related dependencies to dagger.pip package
- Abstract the experiment flag based selection of class to dedicated
  PipModule and expose that only to WMShellModule

Changed also constructors to not register for wm/ shell callbacks by
default. This is to prevent implementations from both legacy and pip2
listening for same events, which can cause undefined behavior.

TODO

- Move shared classes between the legacy and new PiP implementation to a
  separated package
- Refactor PipTransitionController as an interface can be shared in
  between legacy and new implementations, this should be the only
  external dependency for PiP

Bug: 291996784
Test: m -j SystemUIGoogle
Change-Id: I0d15ce2aa77e0452d12a6e8e1fd9568261ec11e0
parent aeb77b50
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment