Solve error prone issues GuardBy, Permission etc.
GuardedBy * To access mProgress and mClientProgress should hold mProgressLock * To access mInstallSource, mSessionApplied, mSessionFailed, mCommitted should hold mLock * remove unnecessary @GuardBy for assertNotChildLocked and change function name to assertNotChild. * Doesn't hold two locks as possible. as TODO(b/197071589) * Suppress GuardedBy for mPm.mInstaller without holding mPm.mInstallerLock UnusedNestedClass * remove UnusedNestedClass that is StreamingException AndroidFrameworkEfficientCollections * change List<Integer> to IntArray AndroidFrameworkEfficientStrings * change from String.format to TextUtils.formatSimp Test: ./build/soong/soong_ui.bash --make-mode services \ RUN_ERROR_PRONE=true Test: atest \ CtsStagedInstallHostTestCases \ CtsPackageInstallTestCases \ CtsAtomicInstallTestCases Test: atest com.android.server.pm.StagingManagerTest Bug: 196675234 Change-Id: I9302115901f0298cdf48fe01d926f9edb96ae23e
Loading
Please register or sign in to comment