Refactor getDestinationBounds into more readable methods
getDestinationBounds(Rect) was only being used to calculate the "entry" bounds (e.g. onTaskAppeared, swipeToHome) and all its callers were passing in null. getDestinationBounds(Rect, boolean) had only one caller, onTaskInfoChanged, who did pass the current bounds in to be adjusted to the aspect ratio. Instead of having overloaded methods and complex logic to know whether to calculate default bounds or use the provided bounds, the method is now split into two methods that better represent what they're calculating: 1. getEntryDestinationBounds, no arguments, calculates either default or reentry bounds 2. getAdjustedDestinationBounds, takes in the current bounds and the new aspect ratio, simply adjusts the bounds to the aspect ratio. Bug: 169373982 Test: atest com.android.wm.shell.pip Change-Id: Ie8adda458fc5a56b9d78245c663dbc54b8525378
Loading
Please register or sign in to comment