Skip to content
Commit 9d5f970c authored by Josh Tsuji's avatar Josh Tsuji
Browse files

Check if the SIM is secure before dispatching swipe to unlock.

Due to an existing bug, KeyguardStateController#canDismissLockScreen
returns true even if the device is SIM-locked, if there is no device
lock set. This caused the new sc-v2 unlock code to believe we could
dismiss the lock screen via swiping. Since the panel expansion is used
to drive swipe to unlock on the lock screen, this meant that swiping
the notification panel over the emergency dialer was interpreted as a
swipe to unlock, so we unlocked.

We'll fix the underlying issue with canDismissLockScreen in T:
b/214057466. This method is used 25+ times all over the code, and it
would be extremely risky to add the SIM-lock check there at this point.

Fixes: 214057466
Test: insert locked SIM, emergency dialer, pull down shade, try to go back/home
Change-Id: Iee86cadc8c4903c703d4fab515dc4f6f73953467
parent 091aba97
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment