Don't recycle replaced nodes in a11y cache
This is a patch for another bug. When the cache refreshes nodes, it marks the transaction to bypass the cache. We still, however, replace the cached node. If we recycle the node as well, we end up refreshing it after it's been recycled and end up with a sealed node in the cache. That node can then be obtained and then throw an exception when a setter is called. These exceptions are almost impossible to debug. I'm going to leave the bug open to roll this CL back and fix the cache's behavior, but this fix seems safer this late. Bug: 35626351 Test: Ran a11y CTS and unit tests. Verified on instrumented master build that the error indeed goes away. Removing one line from unit tests that requires recycling. Change-Id: Icc9a43ee49cf7c6bfa996839b35954faaf31621c
Loading
Please register or sign in to comment