Fix vulnerability in AttributionSource due to incorrect Binder call
AttributionSource uses Binder.getCallingUid to verify the UID of the caller from another process. However, getCallingUid does not always behave as expected. If the AttributionSource is unparceled outside a transaction thread, which is quite possible, getCallingUid will return the UID of the current process instead. If this is a system process, the UID check gets bypassed entirely, meaning any uid can be provided. This patch fixes the vulnerability by enforcing that the AttributionSource be unparceled in a transaction only. If it is not, a SecurityException will be thrown. Bug: 267231571 Test: Smoke test on cuttlefish. Test: v2/android-virtual-infra/test_mapping/presubmit-avd Change-Id: Ic301a8518b8e57e1c9a2c9f2f845e51dca145257
Loading
Please register or sign in to comment