CaptivePortalLogin correctly unregisters callbacks
The NetworkCallback registered by the CaptivePortalLogin activity in onCreate was unregistered in both onDestroy() and done(). In addition done() can be called concurrently from different places (from the webview, from the captive portal test probe, from the activity menu), resulting in incorrectly unregistering the callback more than once. This patch fixes the lifecycle management of the NetworkCallback registered by the CaptivePortalLogin activity so that it is unregistered once only in onDestroy. In addition the done() method is made robust against multiple calls and becomes a no-op after the first call. This avoids multiple calls to CaptivePortal for the same captive portal. Bug: 62497809 Test: tested manually with captive portal setup in the office Change-Id: I77fbeb55cf91d3b44e91d2fecb800dae40279652
Loading
Please register or sign in to comment