Include bubble changes in ranking & move flagging to BubbleExtractor
Previously, only changes to the "allowBubbles" on the channel or package would trigger a ranking change. This bit only indicates that the notification is allowed to bubble -- it doesn't indicate that the notification *is* a bubble. To allow active notifications to become bubbles if the user changes the setting, we need to flag them in response to ranking changes. This CL moves the bubble flagging code into BubbleExtractor that way the flag is always updated during ranking changes. BubbleController listens to ranking changes and adds / removes bubbles based on the ranking. The ranking needs to have an isBubble bit on it because ranking changes won't pipe flag updates through. SysUI uses this bit to flag the entry on SysUI's side. Moves the shortcut getting / validating code into a helper class. Also removes the inline reply requirement. Test: NotificationManagerTest NotificationManagerServiceTest BubbleExtractorTest ShortcutHelperTest BubbleCheckerTest Bug: 149736441 Change-Id: Ib5b62923c123187ae5f7073ec7ca50d7e20c04b1 Merged-In: Ib5b62923c123187ae5f7073ec7ca50d7e20c04b1
Loading
Please register or sign in to comment