Skip to content
Commit 38c6f2bf authored by cecilia's avatar cecilia Committed by Cecilia Hong
Browse files

On Smartspace removal update, only dismiss media recommendation/player

when it's invisible to users.

1. Add the param "immediately" to #onMediaDataLoaded and
on the underlying Smartspace data's removal;
2. #onSmartspaceMediaDataRemoved should only set "immediately" to true
on the user's interaction (e.g. Swipe-to-dismiss);
3. Add #SmartspaceMediaData to preserve the information for a
recommendation's view.
    - This data class is to introduce the field - "isActive", which will be set to false when a) The underlying
Smartspace data is removed; b) The Smartspace rec card is dismissed by
the user.
    - This appraoch is used instead of marking the SmartspaceTarget
instance to be null: the instance needs to be kept around to block the
duplicate Smartspace updates.

Fixes: 187219674
Fixes: 185787575
Test: Local builds
Change-Id: I19c398fa617749a9e643db33865fd2c5f8f9bdc4
parent 9787f776
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment