Skip to content
Commit 1fc7a1d4 authored by Yohei Yukawa's avatar Yohei Yukawa
Browse files

Fix unnecessarily extended View lifetime in IMMS

Currently InputMethodManagerService (IMMS) unnecessarily extends the
lifetime of View objects used to show IME switcher dialog until the
dialog is shown again, because it forgets to clear
IMMS#mSwitchingDialogTitleView with null even after the dialog is
closed.

As a result, roughly 1.5MB of RAM will be unnecessarily consumed by
the system_server once after the IME switcher dialog is shown until
the device is rebooted.

With this CL, IMMS#mSwitchingDialogTitleView will be cleared with null
when the dialog is closed.

Fixes: 78245299
Test: Manually made sure that IMMS does not hold strong references to
      View objects used for IME switcher dialog after the dialog is
      closed.
Change-Id: I9fee92bb2974edeceacc680686095df480efba29
parent df173b59
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment