Skip to content
Commit 1d4fdcb6 authored by Ruchir Rastogi's avatar Ruchir Rastogi
Browse files

Remove obsolete/infeasible TODOs

(a) Clean up LogEvent::parseBuffer - having those variables be member
variables really helps with code readability.

(b) Don't hold locks when writing to pipe within ShellSubscriber -
ag/150969574 describes why holding a lock is necessary.

Test: m
Bug: 150312423 (allows this bug to be marked as obsolete)
Change-Id: I4903de1dc87a552932b70e5975a7cde91df05b3b
parent 17849976
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment