Skip to content
Commit 11844145 authored by Michal Brzezinski's avatar Michal Brzezinski
Browse files

Fixing tiles on lockscreen and scrims transitions with QS expanded

This is quick and safe fix for most bottom tiles not working on lockscreen. We’re updating QS state based on shade transition from KEYGUARD to SHADE_LOCKED. For long term we’d likely prefer to not switch expansion state manually but rather for it to be changed automatically by increasing QS height as it’s done in UNLOCKED state.

Making QS state up-to-date changes scrim transitions as they depend on QS expansion. That caused b/230340979 in the past where scrim is dark for too long when transitioning between shade locked and bouncer. It was mostly caused by qs expansion being interpolated before calculated tint transition - all start and end values are still correct.

The easiest and low risk fix is to adjust scrim transition interpolation and that results in:
- Landscape: it doesn’t keep transition the same, but I think it still looks pretty good and - as a bonus - prevents issue of QS footer background being visible (b/232408997)
- Portrait: Two cases here on lockscreen: going directly to expanded QS or expanding shade and then expanding QS. Both of them didn’t look great to start with but this change makes it a bit better.

This change doesn’t influence handheld transitions as there start and end state tints are the same.

Bug: 228198572
Bug: 232365192
Test: manual
Change-Id: If5c00316bad5ba17a5a359b7ab8bf970ee709121
parent 92e59dde
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment