Skip to content
  1. Oct 07, 2022
  2. Oct 06, 2022
    • Paul Duffin's avatar
      Skip TestBootImageConfig on non-Linux platforms · 3a56f5e0
      Paul Duffin authored
      Bug: 245956352
      Test: m nothing
      Change-Id: I4c0bfd24febd308d8efa62da9603795a7e5ed222
      3a56f5e0
    • Alex Márquez Pérez Muñíz Díaz Púras Thaureaux's avatar
    • Treehugger Robot's avatar
      e81503e1
    • Paul Duffin's avatar
      Merge changes I948c7e51,If917cfbc,I7845b793,Ia815537e · 5b0bba9f
      Paul Duffin authored
      * changes:
        Prevent bootImageVariant.licenseMetadataFile being set twice
        Test bootImageConfig/Variant fields
        Add Config,RunningInsideUnitTest
        Add CommonOs to Config.Targets
      5b0bba9f
    • Chih-hung Hsieh's avatar
      Merge "Add TIDY_EXTERNAL_VENDOR" · 55d3e2ba
      Chih-hung Hsieh authored
      55d3e2ba
    • Treehugger Robot's avatar
    • Alex Márquez Pérez Muñíz Díaz Púras Thaureaux's avatar
      Fix Errorf format string for error · 7a11dc86
      Also go ahead and mark `checkOverrides` as a `t.Helper()`
      
      Test: go test
      Change-Id: I368aabf4d032c02773416f27affa12eb40e77b40
      7a11dc86
    • Alex Márquez Pérez Muñíz Díaz Púras Thaureaux's avatar
      Add Soong tests for cc_prebuilt_binary for bad srcs · b1bd7704
      Test: TestPrebuiltBinary{NoSrcsNoError,MultipleSrcs}
      Change-Id: I1c803e38bae68e452cebf6208412cefed900c7f6
      b1bd7704
    • Jingwen Chen's avatar
      apex bp2build: refactor module names to be more meaningful. · 34feb147
      Jingwen Chen authored
      Numbered module names weren't obvious.
      
      Test: presubmits
      Change-Id: Iee921e2965d1664ed1bccd934ab80f913eff6356
      34feb147
    • Paul Duffin's avatar
      Prevent bootImageVariant.licenseMetadataFile being set twice · 20d90e3e
      Paul Duffin authored
      Previously, in a build containing source and prebuilt art
      bootclasspath_fragments, the bootImageVariant.licenseMetadataFile was
      set twice with the source always being set after the prebuilt and
      so winning.
      
      This change only sets bootImageVariant.licenseMetadataFile for the
      active module so it will use the prebuilt's license file if that is
      preferred.
      
      Bug: 245956352
      Test: m nothing
      Change-Id: I948c7e5123169452f67c85ad98c4bbdb90a5d2de
      20d90e3e
    • Paul Duffin's avatar
      Test bootImageConfig/Variant fields · 8eb4573b
      Paul Duffin authored
      Most of the fields in the bootImageConfig/Variant structs are assigned
      inside a Once func so are guaranteed to be only set once. However, some
      are assigned outside. This change adds comprehensive tests for those
      structs and verifies that the constant fields are preserved and the
      mutated fields have the correct value.
      
      The check for the constant fields is added in a new TestBootImageConfig
      test.
      
      The check for the mutated fields is added into
      TestSnapshotWithBootclasspathFragment_ImageName as that test checks an
      art bootclasspath_fragment in the following configurations:
      * source on its own
      * prebuilt on its own
      * source and prebuilt with source preferred
      * source and prebuilt with prebuilt
      
      It reveals a couple of interesting facts:
      * All the *installs fields are set to the same value irrespective of
        whether the source or prebuilt is preferred. The information is
        constructed solely from information already within the
        bootImageConfig/Variant and so can be moved within Once.
      
      * The licenseMetadataFile is incorrect when prebuilt is preferred.
        That is due to both the source and prebuilt modules setting it and
        the source module always wins as the source module depends on the
        prebuilt so always runs its GenerateAndroidBuildActions after it.
      
      Those issues will be cleaned up in following changes.
      
      Bug: 245956352
      Test: m nothing
      Change-Id: If917cfbcb3b1c842a8682d51cc1ee1fed1c51add
      8eb4573b
    • Paul Duffin's avatar
      Add Config,RunningInsideUnitTest · 74135582
      Paul Duffin authored
      Sometimes it is necessary for some functionality to be disabled while
      running in unit tests, e.g. functionality that requires external
      information such as error prone tools and configuration. Sometimes it
      is necessary for some functionality to be enabled while running in
      unit tests, e.g. functionality that makes state available for
      testing but which is not necessary at runtime.
      
      Previously, that was done by checking to see if TestProductVariables
      was nil. This change adds a method to abstract that.
      
      Bug: 245956352
      Test: m nothing
      Change-Id: I7845b79328e7180623161a9bf897568089da4e4f
      74135582
    • Paul Duffin's avatar
      Add CommonOs to Config.Targets · de13a3a2
      Paul Duffin authored
      Previously, CommonOs was not added to Config.Targets for the test which
      caused AndroidMk to crash when trying to determine if a target needed
      the 2ND_ prefix added to some make variables.
      
      Bug: 245956352
      Test: m nothing
      Change-Id: Ia815537ee5ce8e83df9a01c57250aa888453d138
      de13a3a2
    • Paul Duffin's avatar
      Merge changes I3c73920d,I03b09e51,I09069828 · 298b6b0c
      Paul Duffin authored
      * changes:
        Remove deviceInstalls from bootImageVariant
        Remove profilePathOnHost from bootImageConfig
        Document bootImageConfig and bootImageVariant structs
      298b6b0c
    • Jingwen Chen's avatar
      apex_key bp2build: disambiguate module and src deps. · 1d873331
      Jingwen Chen authored
      (and remove unused keyName field.)
      
      The private_key and public_key props of an apex_key can point to either
      a module or a string. If it's a module, then respect it. If it's a
      string, there's additional product variable lookup to find the apex_key
      files in product_vars's DefaultAppCertificate parent dir.
      
      This is similar to android_app_certificate.
      
      Test: presubmits
      Change-Id: Ib258da14cb0c2df8b5f817fcbc46afebcf225db8
      1d873331
    • Treehugger Robot's avatar
    • Usta (Tsering) Shrestha's avatar
      48f0d042
    • Colin Cross's avatar
      Add aosp_riscv64 to build_test skipped products · 774a1bfd
      Colin Cross authored
      aosp_riscv64 isn't ready for build_test yet, it still requires
      ALLOW_MISSING_DEPENDENCIES=true to build.
      
      Bug: 250918230
      Change-Id: I9151fa84bf6ad0fa67dd06d3268311ae716b5185
      Test: none
      774a1bfd
  3. Oct 05, 2022
Loading