- Oct 07, 2022
-
-
Treehugger Robot authored
-
Treehugger Robot authored
-
Cole Faust authored
The merged build files should be added as ninja dependencies, so we rerun when they're changed. Fixes: 246552590 Test: m bp2build, m bp2build again and observe it didn't rerun. Then add a comment in external/protobuf/BUILD.bazel, run m bp2build again, and observe it reruns Change-Id: I26ed035cc0a894500a192f9aa3371fb46519689b
-
Zi Wang authored
Bug: 240163393 Test: TestBpfWithBazel in bpf_test.go Change-Id: I1d24a9c0d1d6911987c730bf1b5b7e02d6e73a5e
-
Jeremy Meyer authored
Bug: 240322840 Test: unit tests Change-Id: I6b07cf57dc113e3805346e50ef9896471df9f53c
-
Yu Liu authored
-
Trevor Radcliffe authored
-
Paul Duffin authored
-
Lais Andrade authored
-
Treehugger Robot authored
-
Paul Duffin authored
Bug: 245956352 Test: m nothing Change-Id: I6402573b378eee77d802829ec5dfacf4c514d3b8
-
Lais Andrade authored
This reverts commit 5fe655d1. Reason for revert: DroidMonitor: Potential culprit for Bug b/251688241 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted. Change-Id: I1ea4df27557fc891d8f0156ec5681f9b0c601c98
-
Sorin Basca authored
-
Treehugger Robot authored
-
- Oct 06, 2022
-
-
Paul Duffin authored
Bug: 245956352 Test: m nothing Change-Id: I4c0bfd24febd308d8efa62da9603795a7e5ed222
-
-
Treehugger Robot authored
-
Paul Duffin authored
* changes: Prevent bootImageVariant.licenseMetadataFile being set twice Test bootImageConfig/Variant fields Add Config,RunningInsideUnitTest Add CommonOs to Config.Targets
-
Chih-hung Hsieh authored
-
Treehugger Robot authored
-
Also go ahead and mark `checkOverrides` as a `t.Helper()` Test: go test Change-Id: I368aabf4d032c02773416f27affa12eb40e77b40
-
Test: TestPrebuiltBinary{NoSrcsNoError,MultipleSrcs} Change-Id: I1c803e38bae68e452cebf6208412cefed900c7f6
-
Jingwen Chen authored
Numbered module names weren't obvious. Test: presubmits Change-Id: Iee921e2965d1664ed1bccd934ab80f913eff6356
-
Paul Duffin authored
Previously, in a build containing source and prebuilt art bootclasspath_fragments, the bootImageVariant.licenseMetadataFile was set twice with the source always being set after the prebuilt and so winning. This change only sets bootImageVariant.licenseMetadataFile for the active module so it will use the prebuilt's license file if that is preferred. Bug: 245956352 Test: m nothing Change-Id: I948c7e5123169452f67c85ad98c4bbdb90a5d2de
-
Paul Duffin authored
Most of the fields in the bootImageConfig/Variant structs are assigned inside a Once func so are guaranteed to be only set once. However, some are assigned outside. This change adds comprehensive tests for those structs and verifies that the constant fields are preserved and the mutated fields have the correct value. The check for the constant fields is added in a new TestBootImageConfig test. The check for the mutated fields is added into TestSnapshotWithBootclasspathFragment_ImageName as that test checks an art bootclasspath_fragment in the following configurations: * source on its own * prebuilt on its own * source and prebuilt with source preferred * source and prebuilt with prebuilt It reveals a couple of interesting facts: * All the *installs fields are set to the same value irrespective of whether the source or prebuilt is preferred. The information is constructed solely from information already within the bootImageConfig/Variant and so can be moved within Once. * The licenseMetadataFile is incorrect when prebuilt is preferred. That is due to both the source and prebuilt modules setting it and the source module always wins as the source module depends on the prebuilt so always runs its GenerateAndroidBuildActions after it. Those issues will be cleaned up in following changes. Bug: 245956352 Test: m nothing Change-Id: If917cfbcb3b1c842a8682d51cc1ee1fed1c51add
-
Paul Duffin authored
Sometimes it is necessary for some functionality to be disabled while running in unit tests, e.g. functionality that requires external information such as error prone tools and configuration. Sometimes it is necessary for some functionality to be enabled while running in unit tests, e.g. functionality that makes state available for testing but which is not necessary at runtime. Previously, that was done by checking to see if TestProductVariables was nil. This change adds a method to abstract that. Bug: 245956352 Test: m nothing Change-Id: I7845b79328e7180623161a9bf897568089da4e4f
-
Paul Duffin authored
Previously, CommonOs was not added to Config.Targets for the test which caused AndroidMk to crash when trying to determine if a target needed the 2ND_ prefix added to some make variables. Bug: 245956352 Test: m nothing Change-Id: Ia815537ee5ce8e83df9a01c57250aa888453d138
-
Paul Duffin authored
* changes: Remove deviceInstalls from bootImageVariant Remove profilePathOnHost from bootImageConfig Document bootImageConfig and bootImageVariant structs
-
Jingwen Chen authored
(and remove unused keyName field.) The private_key and public_key props of an apex_key can point to either a module or a string. If it's a module, then respect it. If it's a string, there's additional product variable lookup to find the apex_key files in product_vars's DefaultAppCertificate parent dir. This is similar to android_app_certificate. Test: presubmits Change-Id: Ib258da14cb0c2df8b5f817fcbc46afebcf225db8
-
Treehugger Robot authored
-
Usta (Tsering) Shrestha authored
-
Colin Cross authored
aosp_riscv64 isn't ready for build_test yet, it still requires ALLOW_MISSING_DEPENDENCIES=true to build. Bug: 250918230 Change-Id: I9151fa84bf6ad0fa67dd06d3268311ae716b5185 Test: none
-
- Oct 05, 2022
-
-
Yu Liu authored
Bug: 233660582 Test: Manually verified the lib and related flags are present when coverage is enabled. Change-Id: I7f03fbe56acd31016687751d10c73f2e92b2fa8c
-
Inseob Kim authored
-
Chih-Hung Hsieh authored
Allow external/vendor owners and toolchain developers to run clang-tidy with external/vendor files, by setting TIDY_EXTERNAL_VENDOR=1 or true instead of touching .bp or .go files. Bug: 244631413 Test: TIDY_EXTERNAL_VENDOR=1 make tidy-soong_subset Change-Id: I0c903f32eb0e5daa0f8dfa2f6dc892b8f8c4ebcc
-
Treehugger Robot authored
-
Colin Cross authored
-
Usta Shrestha authored
Bug: b/239044089 Test: run build/bazel/ci/incremental_build --bazel-mode com.android.adbd and see the additional metrics in summary.csv Change-Id: I2c3b9cead2ee43c700a9ad52e669a64aab1499ce
-
Colin Cross authored
* changes: Move fuzzer's CollectAllSharedDependencies into GenerateAndroidBuildActions Support AllowMissingDependencies in prebuilt_apex modules Support AllowMissingDependencies for apex dependencies Add AllowMissingDependencies support for prebuilt_etc module with no src property Make OutputFileForModule work for AllowMissingDependencies Fix panics when target arch is riscv64
-
Spandan Das authored
-