- May 12, 2020
-
-
Paul Duffin authored
Visibility rules can be 'inherited' in one of two ways. Either from defaults or from a module that called ctx.CreateModule(...). Previously, in both cases the inheriting module could only append additional visibility rules to the end of the inherited rules. That made it impossible to restrict the visibility by removing or ignore inherited rules. The //visibility:override rectifies that by allowing the inheriting module to ignore all the rules that they would have inherited. It can only go at the beginning of a list of rules specified in a module but after defaults are applied it can end up in the middle of a list of rules. In that case it behaves as if all the rules up to and including the //visibility:override rule were discarded. It can be used with //visibility:private to override //visibility:public and vice versa. Bug: 155787200 Test: m nothing Change-Id: I8a9c9c5a1bdceaee387c08864ae2b34629e0d46f
-
Treehugger Robot authored
-
Treehugger Robot authored
-
Yo Chiang authored
-
Treehugger Robot authored
-
- May 11, 2020
-
-
Paul Duffin authored
Previously, when writing to generatedContents \n characters were quoted (replaced with \\n) so as to allow them to be preserved through ninja/rsp/bash and were unquoted (replaced \\n with \n) just before redirecting to the output file. That meant that any code which wanted to access the contents for other purposes, e.g. testing had to unquote \\n. This change moves the quoting to be part of the code that generates the ninja rule which simplifies any other code that has to access the contents. Without quoting the generated Android.bp files are not formatted properly, are all on one line and completely unreadable. Bug: 156286550 Test: m art-module-sdk and check generated Android.bp file to make sure it is properly formatted. Change-Id: I768c3b96ed08a3daf251730e2a10d9d72338c49a
-
Ramy Medhat authored
Test: presubmit Change-Id: Idd77abddac0a676302226eb62883c74d5d7489af
-
Anton Hansson authored
-
satayev authored
-
Artur Satayev authored
Similar to APEX-deps-info, app deps info produces two lists with transitive dependencies. Bug: 149622332 Test: m NetworkStack-deps-info Change-Id: Ic6d94df3b7b4be5afe328a0abe768beee1a58362 Exempt-From-Owner-Approval: previous patch approved.
-
Treehugger Robot authored
-
Anton Hansson authored
The space after the backtick prevents it working when copy-pasting it into the shell. Test: create lint error => m => cp/pasted command runs successfully Change-Id: I42b8b60d01dcaed34dbde0390eb1691d656a32cf
-
Treehugger Robot authored
-
- May 10, 2020
-
-
Paul Duffin authored
Previously, the information that the java_sdk_library extracted from its child dependencies was determined purely by the type of the dependency and whether it had a tag of the appropriate type. The actual tag itself was ignored. That worked but was a little fragile as it relied on there being no overlap between the types of the dependencies or if there was overlap on the order in which the dependencies were processed and the dependency types were checked to ensure that the correct information was collected. This change makes the information that is extracted dependent on the tag that is used. That makes the behavior much more robust and also simplifes the follow up change which may get the stubs source and API files from separate droidstubs invocations. Changes: * A func field is added to the scopeDependencyTag that is supplied with a dependency from which to extract the information and scopePaths into which the information will be stored. * Each scopeDependencyTag instance supplies its own function. * Various items are renamed to more closely reflect what they actually do. e.g. the apiFileTag is renamed to stubsSourceAndApiTag field because if provides access to both api file and stubs source. Test: m checkapi Bug: 155164730 Change-Id: I4e1861ea67f441f2948a0d7d7053ab0b1169955f
-
Paul Duffin authored
Ensure consistency with java_sdk_library. Bug: 155295806 Test: m checkapi Change-Id: I074e7c865b6b52c7bcf568da3342d8772623ce4f
-
Paul Duffin authored
-
- May 09, 2020
-
-
Paul Duffin authored
-
Paul Duffin authored
-
Paul Duffin authored
-
Treehugger Robot authored
-
- May 08, 2020
-
-
Colin Cross authored
Check that jni_uses_sdk_apis and jni_uses_platform_apis are consistent with sdk_version, and add tests that they select the right variant. Bug: 154665579 Test: app_test.go Change-Id: I544a4f881ba16dacd7e74cd480c095091b3cf667
-
Paul Duffin authored
Change since last attempt: Disable test that breaks on darwin. Adds a test that fails with unknown property android.stubs.versions and then fixes that by marking the field from which that property is created with 'ignored-on-host' and implemented the isHostVariant on *osTypeSpecificInfo. Bug: 155628860 Test: m nothing Change-Id: Ia4e744c9e799d5adaf8a2f761516f568ec363ad4
-
Paul Duffin authored
Adds a filter mechanism that can exclude property values from being included in the common value extraction. That is needed to prevent the snapshot mechanism from generating invalid output for properties that are ignored on host (and have their values cleared) and which are not tagged with `android:"arch_variant"`. Changes: * Updates the documentation of SdkMemberType to explain what effect the 'ignored-on-host' tag has. * Adds some tests for this new mechanism. Bug: 155628860 Test: m nothing Change-Id: Ibafdb6e921ba5abe505bd8a91ca5a1d9c9b5d0cb
-
Paul Duffin authored
Previously, the snapshot code did not know whether a specific property could be arch specific or not and assumed that they all were which meant that it could generate snapshots containing arch specific values for properties that are not arch specific and so would fail when unpacked. This change requires arch specific fields in SdkMemberProperties to be tagged as such using `android:"arch_variant"` (just as in module input property structures). Any property without that must have properties that are common across all variants. Bug: 155628860 Test: m nothing Change-Id: I3df60f0b53ba02ec2c55a80c7da058eac5909d26
-
Greg Kaiser authored
* changes: Revert "Detect invalid arch specific properties in snapshot" Revert "Adds support for 'ignored-on-host'" Revert "Fix snapshot of a host/device cc_library with stubs"
-
Greg Kaiser authored
Revert submission 1302576 Bug: 156054601 Reason for revert: Presumed root cause of build break. Reverted Changes: Ifc8116e11:Detect invalid arch specific properties in snapsho... I7ebd33307:Adds support for 'ignored-on-host' I167b47a13:Fix snapshot of a host/device cc_library with stub... Change-Id: Id7eba0bdde5c579e10e9b42d94a7cfab5f34995f
-
Greg Kaiser authored
Revert submission 1302576 Bug: 156054601 Reason for revert: Presumed root cause of build break. Reverted Changes: Ifc8116e11:Detect invalid arch specific properties in snapsho... I7ebd33307:Adds support for 'ignored-on-host' I167b47a13:Fix snapshot of a host/device cc_library with stub... Change-Id: I2a7ac0ef0232177eefc26542c11dc675d6f4cab2
-
Greg Kaiser authored
Revert submission 1302576 Bug: 156054601 Reason for revert: Presumed root cause of build break. Reverted Changes: Ifc8116e11:Detect invalid arch specific properties in snapsho... I7ebd33307:Adds support for 'ignored-on-host' I167b47a13:Fix snapshot of a host/device cc_library with stub... Change-Id: Ibccce5286605bb71c6be3b3550ba86d8b7e24fa7
-
Liz Kammer authored
-
Paul Duffin authored
Adds two new properties to specify the visibility of the stubs modules (source and library) created by the java_sdk_library. Excludes visibility property from being inherited when creating the module so it can be properly specified by copying across the relevant property. Test: m checkapi Bug: 155164730 Change-Id: Iffdd9f191ff0d74646356ac577560cc38efdd790
-
Paul Duffin authored
-
Paul Duffin authored
-
Daniel Norman authored
-
Paul Duffin authored
Metalava apparently normalizes the SystemApi annotation that was previously used to the form that this change uses so this is effectively a no-op. However, this does make this code more self-consistent and also matches the form that is used in the framework defaults for the mainline modules. Test: m checkapi Bug: 155164730 Change-Id: Ic99b7333730ed8b918d8af72ae7bd6a851c2093a
-
Yo Chiang authored
Replace ALL_MODULES.$(LOCAL_MODULE) with ALL_MODULES.$(my_register_name). Test: TH presubmit build pass Change-Id: Ic1fb859ae458d1c67cc1d3699199ef36476088db
-
Jiyong Park authored
-
Jiyong Park authored
This reverts commit 45b90e79. Reason for revert: breakage https://android-build.googleplex.com/builds/quarterdeck?branch=aosp-master&target=run_bluetooth_host_native_tests&lkgb=6474123&lkbb=6474183&fkbb=6474137 Bug: 156046846 Change-Id: I0df395eaa4cd856ab466925031b21aa4adc3af08 Test: m on full-eng
-
Paul Duffin authored
Adds api scope for the module_lib and adds that to the list of all all available scopes. The scope is generated if and only if the api_surfaces property contains "module_lib". No other changes are needed as the generation of the APIs is completely driven by the allApiScopes array and the information in its contained apiScope structures. Test: m checkapi Bug: 155164730 Change-Id: I7769af6823badca8715a270f86cf53b4e954b7df
-
Paul Duffin authored
Adds a per scope set of properties that allows explicit control over the API surfaces generated. Previously, the term active was used to determine whether it was generated but that was a little abstract and unclear so has been replaced by generated. Test: m nothing Bug: 155164730 Change-Id: I7539d89618b61f6b9d1a4b60cc3f9614b157f0d9
-
Jiyong Park authored
* changes: Prevent statically linking to a lib providing stable C APIs Add GetPathString
-