Add hook to be called after defaults have been applied
Previously, the only way for a module type to create modules (other than defining its own mutator) was to register a LoadHook. However, that is called before defaults are applied so any properties used in that hook cannot take advantage of defaults, e.g. java_sdk_library cannot use defaults to set its sdk_version property and have that affect its child modules. This change adds a new SetDefaultableHook() to DefaultableModule to register a hook that is called after any defaults have been applied. Also adds some tests to ensure that errors in the visibility property introduced in a DefaultableHook are reported in the gather phase of visibility processing. A follow up change will switch java_sdk_library to use that instead of the AddLoadHook() mechanism. Bug: 155295806 Test: m checkapi Merged-In: I13df3115f9e225f7324b6725eaeb16a78cc2538a Change-Id: I13df3115f9e225f7324b6725eaeb16a78cc2538a (cherry picked from commit afa9fa10)
Loading
Please register or sign in to comment