Skip to content
Commit f48e2696 authored by Riley Andrews's avatar Riley Andrews Committed by Channagoud Kadabi
Browse files

android: binder: Fix preemption and locking issues



Squash the binder fixes into single commit.

Disable preemption while holding the global binder lock.

Change-Id: I90fe02cdedb8a5677b900a68528fb443b9204322
Signed-off-by: default avatarRiley Andrews <riandrews@google.com>
Git-repo: https://source.codeaurora.org/quic/la/kernel/msm-4.4


Git-commit: 5c9ce54ca3a66a57e4ebfe3ae71c5733b6bcc579
Signed-off-by: default avatarVikram Mulukutla <markivx@codeaurora.org>

CHROMIUM: android: binder: Fix potential scheduling-while-atomic

Commit f1e7f0a724f6 ("android: binder: Disable preemption while holding
the global binder lock.") re-enabled preemption around most of the sites
where calls to potentially sleeping functions were made, but missed
__alloc_fd(), which can sleep if the fdtable needs to be resized.
Re-enable preemption around __alloc_fd() as well as __fd_install() which
can now sleep in upstream kernels as of commit 8a81252b ("fs/file.c:
don't acquire files->file_lock in fd_install()").

BUG=chrome-os-partner:44012
TEST=Build and boot on Smaug.

Change-Id: I9819c4b95876f697e75b1b84810b6c520d9c33ec
Signed-off-by: default avatarAndrew Bresticker <abrestic@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/308582


Reviewed-by: default avatarStephen Barber <smbarber@chromium.org>
Reviewed-by: default avatarRiley Andrews <riandrews@google.com>
Git-repo: https://source.codeaurora.org/quic/la/kernel/msm-4.4


Git-commit: c267ff1d548ed1bdad6a08f1c70776c5e60d569e
Signed-off-by: default avatarVikram Mulukutla <markivx@codeaurora.org>

android: binder: use copy_from_user_preempt_disabled

To keep the driver consistent, and until we have
fine-grained locking in place.

Change-Id: Idda7ae8df889b5fae5e96bf343ab17782b4c46b1
Signed-off-by: default avatarMartijn Coenen <maco@android.com>
Git-repo: https://android.googlesource.com/kernel/common


Git-commit: 288f5164a4e434939ae92b86dae2768e57ca41ac
Signed-off-by: default avatarPrasad Sodagudi <psodagud@codeaurora.org>
Signed-off-by: default avatarChannagoud Kadabi <ckadabi@codeaurora.org>
parent 58eb1df2
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment