Skip to content
Commit e0ee7785 authored by NeilBrown's avatar NeilBrown
Browse files

md/raid10: fix problem with on-stack allocation of r10bio structure.



A 'struct r10bio' has an array of per-copy information at the end.
This array is declared with size [0] and r10bio_pool_alloc allocates
enough extra space to store the per-copy information depending on the
number of copies needed.

So declaring a 'struct r10bio on the stack isn't going to work.  It
won't allocate enough space, and memory corruption will ensue.

So in the two places where this is done, declare a sufficiently large
structure and use that instead.

The two call-sites of this bug were introduced in 3.4 and 3.5
so this is suitable for both those kernels.  The patch will have to
be modified for 3.4 as it only has one bug.

Cc: stable@vger.kernel.org
Reported-by: default avatarIvan Vasilyev <ivan.vasilyev@gmail.com>
Tested-by: default avatarIvan Vasilyev <ivan.vasilyev@gmail.com>
Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent 667a5313
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment