Skip to content
Commit 1bf145fe authored by Stefan Richter's avatar Stefan Richter
Browse files

firewire: net: fix unicast reception RCODE in failure paths



The incoming request hander fwnet_receive_packet() expects subsequent
datagram handling code to return non-zero on errors.  However, almost
none of the failure paths did so.  Fix them all.

(This error reporting is used to send and RCODE_CONFLICT_ERROR to the
sender node in such failure cases.  Two modes of failure exist:  Out of
memory, or firewire-net is unaware of any peer node to which a fragment
or an ARP packet belongs.  However, it is unclear whether a sender can
actually make use of such information.  A Linux peer apparently can't.
Maybe it should all be simplified to void functions.)

Reported-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarStefan Richter <stefanr@s5r6.in-berlin.de>
parent a481e97d
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment