Skip to content
Commit bc664cd0 authored by Ben Hutchings's avatar Ben Hutchings Committed by Gerrit - the friendly Code Review server
Browse files

pipe: Fix buffer offset after partially failed read

Quoting the RHEL advisory:

> It was found that the fix for CVE-2015-1805 incorrectly kept buffer
> offset and buffer length in sync on a failed atomic read, potentially
> resulting in a pipe buffer state corruption. A local, unprivileged user
> could use this flaw to crash the system or leak kernel memory to user
> space. (CVE-2016-0774, Moderate)

The same flawed fix was applied to stable branches from 2.6.32.y to
3.14.y inclusive, and I was able to reproduce the issue on 3.2.y.
We need to give pipe_iov_copy_to_user() a separate offset variable
and only update the buffer offset if it succeeds.

References: https://rhn.redhat.com/errata/RHSA-2016-0103.html
cherry picked from commit feae3ca2e5e1a8f44aa6290255d3d9709985d0b2)
Git-commit: feae3ca2e5e1a8f44aa6290255d3d9709985d0b2
Git-repo  : https://android.googlesource.com/kernel/common


change-Id: I988802f38acf40c7671fa0978880928b02d29b56
Signed-off-by: default avatarSrinivasa Rao Kuppala <srkupp@codeaurora.org>
parent adc01bdf
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment