Skip to content
Commit a390eb9a authored by Rainer Weikusat's avatar Rainer Weikusat Committed by Gerrit - the friendly Code Review server
Browse files

af_unix: Guard against other == sk in unix_dgram_sendmsg



The unix_dgram_sendmsg routine use the following test

if (unlikely(unix_peer(other) != sk && unix_recvq_full(other))) {

to determine if sk and other are in an n:1 association (either
established via connect or by using sendto to send messages to an
unrelated socket identified by address). This isn't correct as the
specified address could have been bound to the sending socket itself or
because this socket could have been connected to itself by the time of
the unix_peer_get but disconnected before the unix_state_lock(other). In
both cases, the if-block would be entered despite other == sk which
might either block the sender unintentionally or lead to trying to unlock
the same spin lock twice for a non-blocking send. Add a other != sk
check to guard against this.

Change-Id: I6ceb53e04c67ae73f36268aa93d85733268f3482
Fixes: 7d267278a9ec ("unix: avoid use-after-free in ep_remove_wait_queue")
Reported-By: default avatarPhilipp Hahn <pmhahn@pmhahn.de>
Signed-off-by: default avatarRainer Weikusat <rweikusat@mobileactivedefense.com>
Tested-by: default avatarPhilipp Hahn <pmhahn@pmhahn.de>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Git-repo: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git


Git-commit: a5527dda344fff0514b7989ef7a755729769daa1
Signed-off-by: default avatarRavi Kumar Siddojigari <rsiddoji@codeaurora.org>
parent 1a5dc2a5
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment