tcp: make challenge acks less predictable
Yue Cao claims that current host rate limiting of challenge ACKS (RFC 5961) could leak enough information to allow a patient attacker to hijack TCP sessions. He will soon provide details in an academic paper. This patch increases the default limit from 100 to 1000, and adds some randomization so that the attacker can no longer hijack sessions without spending a considerable amount of probes. Based on initial analysis and patch from Linus. Note that we also have per socket rate limiting, so it is tempting to remove the host limit in the future. v2: randomize the count of challenge acks per second, not the period. Fixes: 282f23c6 ("tcp: implement RFC 5961 3.2") Reported-by: Yue Cao <ycao009@ucr.edu> Signed-off-by: Eric Dumazet <edumazet@google.com> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> Cc: Yuchung Cheng <ycheng@google.com> Cc: Neal Cardwell <ncardwell@google.com> Acked-by: Neal Cardwell <ncardwell@google.com> Acked-by: Yuchung Cheng <ycheng@google.com> Signed-off-by: David S. Miller <davem@davemloft.net> Change-Id: I9818e7d904aa39ce4327042233e3d0ef5982ce4f Git-commit: 75ff39ccc1bd5d3c455b6822ab09e533c551f758 Git-repo: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git [rsiddoji@codeaurora.org: resolved trival conflits and removed the usages of READ_ONCE and WRITE_ONCE macro usage] Signed-off-by: Ravi Kumar Siddojigari <rsiddoji@codeaurora.org>
Loading
Please register or sign in to comment