- Oct 05, 2020
-
-
eta authored
- In some places, we weren't nulling out references to destroyed objects. This fixes that. - (These were all discovered via LeakCanary instrumentation, and the fixes are hopefully rather straightforward-looking.)
-
eta authored
- When the `viewHolder.messageBody` `TextView` created by a `MessageAdapter` is set to selectable, it leaks an `android.widget.Editor` (because that editor registers a view observer that never gets unregistered). - This memory leak is really quite problematic, as the message adapter is used a lot! - Having the text be selectable is useless anyway, though; there isn't any way to select it (because long pressing just opens the context menu anyway). - It looks like the ListSelectionManager was meant to track selections across multiple messages. However, I'm not sure this feature ever gets used. - Accordingly, this commit removes the entire feature, thus fixing the memory leak (since no `Editor` objects are ever created). - It should also reduce memory usage in general, since we aren't attaching an `Editor` to every single textview we create. - A `TextView` only allocates an `Editor` if you ask it to do certain things, like make the text selectable or register custom selection callbacks.
-
- Sep 11, 2020
-
-
Daniel Gultsch authored
-
- Sep 09, 2020
-
-
Daniel Gultsch authored
-
Daniel Gultsch authored
-
- Sep 02, 2020
-
-
Daniel Gultsch authored
leaving a MUC before joining it was a work around for servers that did not treat a <x/> join as a full join and didn’t send the full user list if they thought the user was still in the room. this happens if Conversations restarts after an inproper disconnect. The MUC will think the user is still in the room. however nowadays most modern servers will treat <x/> joins as full joins. on the user hand leave before join would trigger flood prevention on ejabberds and race the first message with the actual join (making the message arrive before the user is considered in the room)
-
Daniel Gultsch authored
-
- Sep 01, 2020
-
-
Daniel Gultsch authored
we don’t want 'manage accounts' and 'settings' to show up when within a conversation. we also move out disable notifications and add to favorites into an overflow overflow to make the menu shorter (after adding 'Search messages' it became very crowded)
-
Daniel Gultsch authored
-
Daniel Gultsch authored
-
Daniel Gultsch authored
-
- Aug 31, 2020
-
-
Daniel Gultsch authored
-
Daniel Gultsch authored
-
Daniel Gultsch authored
-
Daniel Gultsch authored
-
Daniel Gultsch authored
-
Daniel Gultsch authored
-
Daniel Gultsch authored
-
Daniel Gultsch authored
-
Daniel Gultsch authored
-
Daniel Gultsch authored
-
Daniel Gultsch authored
-
Daniel Gultsch authored
-
Daniel Gultsch authored
-
- Aug 29, 2020
-
-
Daniel Gultsch authored
-
- Aug 24, 2020
-
-
Daniel Gultsch authored
-
Daniel Gultsch authored
-
- Aug 22, 2020
-
-
Daniel Gultsch authored
Conversations would attempt to feed any candidates found in the session-accept into WebRTC; even if the session wasn’t setup correctly. this commit processes the candidates only if the session was setup correctly fixes #3867
-
- Aug 19, 2020
-
-
Daniel Gultsch authored
-
Daniel Gultsch authored
-
Daniel Gultsch authored
-
- Aug 05, 2020
-
-
Daniel Gultsch authored
fixes #3854
-
- Aug 03, 2020
-
-
Daniel Gultsch authored
-
- Aug 01, 2020
-
-
Daniel Gultsch authored
-
Daniel Gultsch authored
fixes #3849
-
Daniel Gultsch authored
fixes #3847
-
Daniel Gultsch authored
JingleRTPConnection shuts down the WebRTCWrapper before transitioning into a terminal state. (This allows us to make sure it is actually closed when reaching that state); However that means that, when we get a UI redrawn inbetween closing and transitioning we might still be in SESSION_ACCEPTED but with no PeerConnection. This traditionally has triggered an IllegalStateException on getting the EndUserState. This commit catches the ISE and returns 'ENDING' instead. Chances are that this is only visibiliy for a very brief time in the UI before the transition triggers the UI to redraw with the proper state. fixes #3848
-
- Jul 30, 2020
-
-
Daniel Gultsch authored
-
Daniel Gultsch authored
-
Daniel Gultsch authored
-