Unverified Commit 6db6a615 authored by Christian Clauss's avatar Christian Clauss Committed by GitHub
Browse files

Do not use bare `except:` 

Do not use bare `except:`, it also catches unexpected events like memory errors, interrupts, system exit, and so on.  Prefer `except Exception:`.  If you're sure what you're doing, be explicit and write `except BaseException:`.
parent 79a3963c

core.py

+7 −11
Original line number Diff line number Diff line
@@ -11,20 +11,17 @@ from typing import Tuple 




def clear_screen():

    if system() == "Linux":

        os.system("clear")

    if system() == "Windows":

        os.system("cls")

    os.system("cls" if system() == "Windows" else "clear")





def validate_input(ip, val_range):

    val_range = val_range or []

    try:

        ip = int(ip)

        if ip in val_range:

            return ip

        else:

            return None

    except:

    except Exception:

        pass

    return None
@@ -46,8 +43,7 @@ class HackingTool(object): 


    def __init__(self, options = None, installable: bool = True,

                 runnable: bool = True):

        if options is None:

            options = []

        options  = options or []

        if isinstance(options, list):

            self.OPTIONS = []

            if installable:
@@ -176,7 +172,7 @@ class HackingToolsCollection(object): 
        except (TypeError, ValueError):

            print("Please enter a valid option")

            input("\n\nPress ENTER to continue:")

        except Exception as e:

        except Exception:

            print_exc()

            input("\n\nPress ENTER to continue:")

        return self.show_options(parent = parent)