Unverified Commit 6ad3b841 authored by dependabot[bot]'s avatar dependabot[bot] Committed by GitHub
Browse files

build(deps): bump actions/cache from 4 to 5 (#59) 



Co-authored-by: default avatardependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: default avatarTom Moulard <tom.moulard@perfectstay.com>
parent e09927bd

.github/workflows/healthcheck.workflow.tmpl.yml

+1 −1
Original line number Diff line number Diff line
@@ -24,7 +24,7 @@ jobs: 
        with:

          version: '2.20.2'

      - name: 'Caching'

        uses: 'actions/cache@v4'

        uses: 'actions/cache@v5'

        with:

          path: '/var/lib/docker/'

          key: '${{ runner.os }}-health-${{ github.job }}'

pihole/README.md

+17 −24
Original line number Diff line number Diff line
@@ -19,9 +19,8 @@ settings, blocklists, and DHCP leases. 
## Environment variables



| Variable                   | Default          | Description                                                        |

| --- | --- | --- |

| -------------------------- | ---------------- | ------------------------------------------------------------------ |

| `PIHOLE_IMAGE_VERSION`     | `2024.05.0`      | Pi-hole Docker image tag                                           |

| `PIHOLE_WEBPASSWORD` | `changeme` | Admin UI password; override in `.env` |

| `PIHOLE_V4_ADDRESS`        | `0.0.0.0`        | IP address Pi-hole advertises to clients                           |

| `PIHOLE_V6_ADDRESS`        | `::`             | IPv6 address Pi-hole advertises                                    |

| `PIHOLE_HOSTNAME`          | `pihole`         | Hostname shown in the UI and DHCP replies                          |
@@ -39,8 +38,7 @@ settings, blocklists, and DHCP leases. 
The DNS port exposed to your network is now configured globally via

`TRAEFIK_DNS_ENTRYPOINT` and defaults to 53.



Update `.env` (copied from `.env.default`) with secure values, especially

`PIHOLE_WEBPASSWORD`.

Update `.env` (copied from `.env.default`) with secure values.



## DNS port requirements
@@ -66,11 +64,6 @@ that port before starting Traefik, otherwise Traefik cannot bind to it. 
  any Pi-hole ports.

- Certificates are handled by Traefik via the globally configured ACME resolver.



The admin UI relies on Pi-hole’s own `WEBPASSWORD`. If you want an additional

basic-auth prompt, add the standard middleware labels from the `traefik` service

(or create a dedicated middleware in `dynamic_conf/`) before exposing the route.





## DNS configuration steps



1. Deploy the service: `SITE=example.com docker-compose up -d pihole` (or run the

pihole/docker-compose.pihole.yml

+0 −1
Original line number Diff line number Diff line
@@ -27,7 +27,6 @@ services: 
      traefik.http.routers.pihole.entrypoints: 'websecure'

      traefik.http.routers.pihole.middlewares: 'basic_auth@docker'

      traefik.http.routers.pihole.rule: 'Host(`pihole.${SITE:-localhost}`)'

      traefik.http.routers.pihole.tls: true

      traefik.http.services.pihole.loadbalancer.server.port: 80

      traefik.tcp.routers.pihole-dns.entrypoints: 'dns-tcp'

      traefik.tcp.routers.pihole-dns.rule: 'HostSNI(`*`)'

test_config.yml

+1 −2
Original line number Diff line number Diff line
@@ -1184,7 +1184,6 @@ services: 
      REV_SERVER_TARGET: 192.168.0.1

      TZ: Europe/Paris

      VIRTUAL_HOST: pihole.localhost

      WEBPASSWORD: ""

    healthcheck:

      test:

      - CMD
@@ -1197,8 +1196,8 @@ services: 
    labels:

      traefik.enable: "true"

      traefik.http.routers.pihole.entrypoints: websecure

      traefik.http.routers.pihole.middlewares: basic_auth@docker

      traefik.http.routers.pihole.rule: Host(`pihole.localhost`)

      traefik.http.routers.pihole.tls: "true"

      traefik.http.services.pihole.loadbalancer.server.port: "80"

      traefik.tcp.routers.pihole-dns.entrypoints: dns-tcp

      traefik.tcp.routers.pihole-dns.rule: HostSNI(`*`)