Skip to content
Commit 3310225d authored by Wu Fengguang's avatar Wu Fengguang
Browse files

lib: proportion: lower PROP_MAX_SHIFT to 32 on 64-bit kernel



PROP_MAX_SHIFT should be set to <=32 on 64-bit box. This fixes two bugs
in the below lines of bdi_dirty_limit():

	bdi_dirty *= numerator;
	do_div(bdi_dirty, denominator);

1) divide error: do_div() only uses the lower 32 bit of the denominator,
   which may trimmed to be 0 when PROP_MAX_SHIFT > 32.

2) overflow: (bdi_dirty * numerator) could easily overflow if numerator
   used up to 48 bits, leaving only 16 bits to bdi_dirty

Cc: <stable@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Reported-by: default avatarIlya Tumaykin <librarian_rus@yahoo.com>
Tested-by: default avatarIlya Tumaykin <librarian_rus@yahoo.com>
Signed-off-by: default avatarWu Fengguang <fengguang.wu@intel.com>
parent 15eb77a0
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment