Commit eb4c56b5 authored by Young Xiao's avatar Young Xiao Committed by Xponential31
Browse files

Bluetooth: hidp: fix buffer overflow 



commit a1616a5ac99ede5d605047a9012481ce7ff18b16 upstream.

Struct ca is copied from userspace. It is not checked whether the "name"
field is NULL terminated, which allows local users to obtain potentially
sensitive information from kernel stack memory, via a HIDPCONNADD command.

This vulnerability is similar to CVE-2011-1079.

Signed-off-by: default avatarYoung Xiao <YangX92@hotmail.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 7d4b4f59

net/bluetooth/hidp/sock.c

+1 −0
Original line number Diff line number Diff line
@@ -76,6 +76,7 @@ static int hidp_sock_ioctl(struct socket *sock, unsigned int cmd, unsigned long 
			sockfd_put(csock);

			return err;

		}

		ca.name[sizeof(ca.name)-1] = 0;



		err = hidp_connection_add(&ca, csock, isock);

		if (!err && copy_to_user(argp, &ca, sizeof(ca)))