Commit 56853606 authored by Jordan Niethe's avatar Jordan Niethe Committed by DidntRead
Browse files

powerpc/powernv: Make opal log only readable by root 



commit 7b62f9bd2246b7d3d086e571397c14ba52645ef1 upstream.

Currently the opal log is globally readable. It is kernel policy to
limit the visibility of physical addresses / kernel pointers to root.
Given this and the fact the opal log may contain this information it
would be better to limit the readability to root.

Fixes: bfc36894a48b ("powerpc/powernv: Add OPAL message log interface")
Cc: stable@vger.kernel.org # v3.15+
Signed-off-by: default avatarJordan Niethe <jniethe5@gmail.com>
Reviewed-by: default avatarStewart Smith <stewart@linux.ibm.com>
Reviewed-by: default avatarAndrew Donnellan <andrew.donnellan@au1.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f93d1e03

arch/powerpc/platforms/powernv/opal-msglog.c

+1 −1
Original line number Diff line number Diff line
@@ -92,7 +92,7 @@ out: 
}



static struct bin_attribute opal_msglog_attr = {

	.attr = {.name = "msglog", .mode = 0444},

	.attr = {.name = "msglog", .mode = 0400},

	.read = opal_msglog_read

};