Commit 24cf887a authored by Changbin Du's avatar Changbin Du Committed by DidntRead
Browse files

perf top: Fix error handling in cmd_top() 



[ Upstream commit 70c819e4bf1c5f492768b399d898d458ccdad2b6 ]

We should go to the cleanup path, to avoid leaks, detected using gcc's
ASan.

Signed-off-by: default avatarChangbin Du <changbin.du@gmail.com>
Reviewed-by: default avatarJiri Olsa <jolsa@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/20190316080556.3075-9-changbin.du@gmail.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent be2625e7

tools/perf/builtin-top.c

+3 −2
Original line number Diff line number Diff line
@@ -1256,8 +1256,9 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused) 
	symbol_conf.priv_size = sizeof(struct annotation);



	symbol_conf.try_vmlinux_path = (symbol_conf.vmlinux_name == NULL);

	if (symbol__init(NULL) < 0)

		return -1;

	status = symbol__init(NULL);

	if (status < 0)

		goto out_delete_evlist;



	sort__setup_elide(stdout);