Commit 1742616c authored by Kangjie Lu's avatar Kangjie Lu Committed by DidntRead
Browse files

ALSA: echoaudio: add a check for ioremap_nocache 



[ Upstream commit 6ade657d6125ec3ec07f95fa51e28138aef6208f ]

In case ioremap_nocache fails, the fix releases chip and returns
an error code upstream to avoid NULL pointer dereference.

Signed-off-by: default avatarKangjie Lu <kjlu@umn.edu>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 95ed6b8d

sound/pci/echoaudio/echoaudio.c

+5 −0
Original line number Diff line number Diff line
@@ -1990,6 +1990,11 @@ static int snd_echo_create(struct snd_card *card, 
	}

	chip->dsp_registers = (volatile u32 __iomem *)

		ioremap_nocache(chip->dsp_registers_phys, sz);

	if (!chip->dsp_registers) {

		dev_err(chip->card->dev, "ioremap failed\n");

		snd_echo_free(chip);

		return -ENOMEM;

	}



	if (request_irq(pci->irq, snd_echo_interrupt, IRQF_SHARED,

			KBUILD_MODNAME, chip)) {