- Apr 29, 2022
-
-
Adenilson Cavalcanti authored
The last two changes came from the 'develop' branch of canonical zlib and should address some issues on 1.2.12 that are going to be featured on the upcoming 1.2.12.x. With this patch landing, Chromium's zlib will be 1.2.12 + fixes (plus our optimizations). Ported: - Eliminate use of ULL constants. - Fix crc32.c to compile local functions only if used. - zlib 1.2.12 - Silence some warnings from Visual Studio C. - Correct incorrect inputs provided to the CRC functions. Bug: 1032721 Change-Id: I3903ae4de5f42427fae1cca8052ad300f5a07b30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3611239 Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/main@{#997532} NOKEYCHECK=True GitOrigin-RevId: 9eb3d1c886a4dd302304241e74a75127e2069d17
-
- Apr 28, 2022
-
-
Adenilson Cavalcanti authored
Ported: - Avoid adding empty gzip member after gzflush with Z_FINISH. - Fix error in comment on the polynomial representation of a byte. - Clarify gz* function interfaces, referring to parameter names. - Change macro name in inflate.c to avoid collision in VxWorks. - Replace black/white with allow/block. (theresa-m) - Add fallthrough comments for gcc. Bug: 1032721 Change-Id: Iddabef8450dca9dced3df58473a0ecb197796dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3611483 Reviewed-by:
-
- Apr 26, 2022
-
-
Adenilson Cavalcanti authored
This time we add an extra guard where it is required to explicitly activate the new Armv8.1 CRC-32 provided by zlib 1.2.12 (i.e. USE_CANONICAL_ARMV8_CRC32) since we measured and the serial implementation that we ship since early 2018 is slightly faster. Ported: - Add use of the ARMv8 crc32 instructions when requested. - Use ARM crc32 instructions if the ARM architecture has them. - Explicitly note that the 32-bit check values are 32 bits. Bug: 1032721 Change-Id: I0ca87270ef470de243e62e9056ed0cd195da21ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3607702 Reviewed-by:
-
Findit authored
This reverts commit 096d2447f2fdecf9693db32ba50858d5e31cca34. Reason for revert: Findit (https://goo.gl/kROfz5) identified this CL at revision 096d2447f2fdecf9693db32ba50858d5e31cca34 as the culprit for failures in the continuous build including: Sample Failed Build: https://ci.chromium.org/b/8815840511093637041 Sample Failed Step: compile If it is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?status=Available&comment=Datastore+key+for+the+culprit+entity%3A+chromium.googlesource.com%2Fchromium%2Fsrc%2Frefs%2Fheads%2Fmain%2F096d2447f2fdecf9693db32ba50858d5e31cca34&labels=Test-Findit-Wrong&components=Tools%3ETest%3EFindIt&summary=Wrongly+blame+096d2447f2fdecf9693db32ba50858d5e31cca34 Original change's description: > [zlib] Re-sync with zlib 1.2.12, patch 13 of N > > Ported: > - Add use of the ARMv8 crc32 instructions when requested. > - Use ARM crc32 instructions if the ARM architecture has them. > - Explicitly note that the 32-bit check values are 32 bits. > > Bug: 1032721 > Change-Id: Ic988198b20de6f59c5fbcd3d37a33d2594380b28 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3607170 > Reviewed-by:
Christopher Lam <calamity@chromium.org> Commit-Queue: Christopher Lam <calamity@chromium.org> Owners-Override: Christopher Lam <calamity@chromium.org> Cr-Commit-Position: refs/heads/main@{#996033} NOKEYCHECK=True GitOrigin-RevId: 7acb20d251cd57c13e3f04fa41be7b9c83d06d5e
-
Adenilson Cavalcanti authored
Ported: - Add use of the ARMv8 crc32 instructions when requested. - Use ARM crc32 instructions if the ARM architecture has them. - Explicitly note that the 32-bit check values are 32 bits. Bug: 1032721 Change-Id: Ic988198b20de6f59c5fbcd3d37a33d2594380b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3607170 Reviewed-by:
-
- Apr 25, 2022
-
-
Adenilson Cavalcanti authored
Ported: - Use atomic test and set, if available, for dynamic CRC tables - Correct comment in crc32.c Bug: 1032721 Change-Id: Iabbfb759c83fc629f3d618e3b6aee98fa50b6aee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3605954 Reviewed-by:
-
- Apr 22, 2022
-
-
Adenilson Cavalcanti authored
Ported: - Add tables for crc32_combine(), to speed it up by a factor of 200 - Add crc32_combine_gen() and crc32_combine_op() for fast combines - Speed up software CRC-32 computation by a factor of 1.5 to 3 Bug: 1032721 Change-Id: Ia6a1fd31e5d264813e2d6bb307d95123c855240c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3584144 Reviewed-by:
-
- Apr 21, 2022
-
-
Adenilson Cavalcanti authored
This change will allow Chromium's zlib to use the portable hash function provided by canonical zlib (i.e. Rabin-Karp). This switch is available during compiling time, but it will regress compression performance. Bug: 1316541 Change-Id: Ie2f3662c60221a7a0cc4d8d7b65745994a797e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3587609 Reviewed-by:
-
Noel Gordon authored
This is a just CHROMIUM_ZLIB_NO_CASTAGNOLI synonym and can be used in chromium zlib code to guard UPDATE_HASH fixes. Add references, to explain Rabin-Karp use in zlib, for the curious. Not used yet, so no change in behavior. Bug: 1316541 Change-Id: I321bf7c245c1ca63ead4627f17cf1d58f7d98b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3587989 Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
-
- Apr 20, 2022
-
-
Noel Gordon authored
After CL:1960893, there are no calls to crc32_simd.h API anymore from deflate.c code. Remove this unused include file. No change in behavior. Bug: 1316541 Change-Id: Ia5953ef1536310970e006d82f8e9a4a836c8acc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3592421 Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/main@{#994195} NOKEYCHECK=True GitOrigin-RevId: f480d12c204852ebe388183a8e3ae67952a80038
-
- Apr 19, 2022
-
-
Noel Gordon authored
If --check option is given, compress the input file. Report the length of the compresssed data, and the crc32 of the compressed data. For the GZIP and ZLIB DEFLATE stream types, also report the data those stream types [1] store at the end of the compressed data. Add the --check option to program usage message. Also change the usage message to always report the zlib verion number. [1] See RFC-1952 GZIP, RFC 1950 ZLIB. Bug: 798943,1316541 Change-Id: Id9d5a918b3ae142077d654f82ca6c9bd40762cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3591994 Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
-
- Apr 11, 2022
-
-
Adenilson Cavalcanti authored
Validated build is fine for V8@Win10 with MSVC. Ported: - Avoid the use of ptrdiff_t Bug: 1032721 Change-Id: I27c290bf29321c3000ffd8edfa53f21b900859d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3579804 Reviewed-by:
-
- Apr 07, 2022
-
-
François Degros authored
Made zlib tests ZipTest.UnzipWindowsSpecialNames and ZipTest.UnzipMixedPaths more lenient on Windows to accommodate different versions on Windows. BUG=chromium:1313991 TEST=autoninja -C out/Default zlib_unittests && out/Default/zlib_unittests Change-Id: I7217629de35d07040cb175327ca51e61f48a6d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3573798 Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/main@{#989698} NOKEYCHECK=True GitOrigin-RevId: 6ccf672cf8a6b7035cda082db440f97b4edadc86
-
- Apr 06, 2022
-
-
Adenilson Cavalcanti authored
Ported: - Don't bother computing check value after successful inflateSync() Bug: 1032721 Change-Id: If96f53a341203df3b68e63d01136b5287269b62b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3574954 Reviewed-by:
-
Adenilson Cavalcanti authored
Missed this change in patchset 5. Ported: - Don't compute check value for raw inflate if asked to validate - Handle case where inflateSync used when header never processed Bug: 1032721 Change-Id: Idbc1fa4cd36a18ab5e775469406984ac2ebb27eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3575094 Reviewed-by:
-
Adenilson Cavalcanti authored
Ported: - Fix deflateEnd() to not report an error at start of raw deflate - Emphasize the need to continue decompressing gzip members - Correct the initialization requirements for deflateInit2() - Assure that the number of bits for deflatePrime() is valid Bug: 1032721 Change-Id: I6c1cbf67b8c983ddc4481a445982f226bc97ceb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3573054 Reviewed-by:
-
- Apr 04, 2022
-
-
Adenilson Cavalcanti authored
Ported: - Avoid undefined behaviors of memcpy() in gz*printf() - Avoid an undefined behavior of memcpy() in _tr_stored_block() - Make the names in functions declarations identical to definitions Bug: 1032721 Change-Id: I0c7aa9d175448f8753e640b91bb31c3d971248e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3570083 Reviewed-by:
-
- Apr 02, 2022
-
-
Adenilson Cavalcanti authored
Ported: - Don't compute check value for raw inflate if asked to validate - Handle case where inflateSync used when header never processed Bug: 1032721 Change-Id: If83342fc0df3b9d2bcb0c19c42065c2b28fc3a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3564231 Reviewed-by:
-
- Apr 01, 2022
-
-
Daniel Rubery authored
This CL removes the check in ZipReader that the target file is empty. We can't truncate the file within the sandbox on MacOS, so we're forced to overwrite the first few bytes for each entry in the zip. This was recently forbidden by ZipReader, so reverse that part of the change. This CL also adds a few lines that would have made debugging this easier. In the future, instead of just knowing the hash of b.zip is e3b0c4..., we'll be explicitly told the entry was empty and truncation failed. Fixed: 1309879 Change-Id: Idd34436df21f55f643b12d024401b7cb7e3e4138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3563962 Reviewed-by:
Rohit Bhatia <bhatiarohit@google.com> Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/main@{#987758} NOKEYCHECK=True GitOrigin-RevId: 458293487a3211c5f15882d3fe3e4fecbddad333
-
- Mar 31, 2022
-
-
Adenilson Cavalcanti authored
Ported: - Small speedup to inflate [psumbera] It seems to be around +1% improvement in decompression: adenilson@Adenilsons-Air tot % ./zlib_bench gzip ~/corpus/flex/* /Users/adenilson/corpus/flex/baddata1.snappy : GZIP: [b 1M] bytes 27512 -> 22920 83.31% comp 66.8 ( 67.1) MB/s uncomp 234.0 (235.6) MB/s /Users/adenilson/corpus/flex/geo.protodata : GZIP: [b 1M] bytes 118588 -> 15124 12.75% comp 154.4 (154.7) MB/s uncomp 1310.5 (1311.6) MB/s /Users/adenilson/corpus/flex/html_x_4 : GZIP: [b 1M] bytes 409600 -> 53285 13.01% comp 107.2 (107.4) MB/s uncomp 1174.3 (1179.1) MB/s /Users/adenilson/corpus/js-data.txt : GZIP: [b 1M] bytes 122903539 -> 37369556 30.41% comp 46.1 ( 46.1) MB/s uncomp 562.6 (563.2) MB/s /Users/adenilson/corpus/linux-5.6-rc3.tar : GZIP: [b 1M] bytes 957450240 -> 180809431 18.88% comp 61.1 ( 61.5) MB/s uncomp 738.0 (747.2) MB/s adenilson@Adenilsons-Air psumbera % ./zlib_bench gzip ~/corpus/flex/* /Users/adenilson/corpus/flex/baddata1.snappy : GZIP: [b 1M] bytes 27512 -> 22920 83.31% comp 66.0 ( 66.6) MB/s uncomp 236.7 (239.2) MB/s /Users/adenilson/corpus/flex/geo.protodata : GZIP: [b 1M] bytes 118588 -> 15124 12.75% comp 154.6 (154.8) MB/s uncomp 1322.3 (1328.8) MB/s /Users/adenilson/corpus/flex/html_x_4 : GZIP: [b 1M] bytes 409600 -> 53285 13.01% comp 107.3 (107.5) MB/s uncomp 1185.4 (1187.1) MB/s /Users/adenilson/corpus/js-data.txt : GZIP: [b 1M] bytes 122903539 -> 37369556 30.41% comp 46.0 ( 46.1) MB/s uncomp 565.4 (566.0) MB/s /Users/adenilson/corpus/linux-5.6-rc3.tar : GZIP: [b 1M] bytes 957450240 -> 180809431 18.88% comp 61.5 ( 62.1) MB/s uncomp 749.9 (836.4) MB/s Bug: 1032721 Change-Id: Iabf6f5c5cc94a4e8219c22831246cd353ddc7d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3563969 Reviewed-by:
-
Adenilson Cavalcanti authored
Ported: - Avoid some conversion warnings in gzread.c and gzwrite.c - Update use of errno for newer Windows CE versions - Return an error if the gzputs string length can't fit in an int Bug: 1032721 Change-Id: I84189ebed1bca346b37221b3325249f14fd2d4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3562224 Reviewed-by:
-
Adenilson Cavalcanti authored
Ported: - Fix bug when window full in deflate_stored() - Fix CLEAR_HASH macro to be usable as a single statement - Avoid a conversion error in gzseek when off_t type too small Bug: 1032721 Change-Id: I0f023f57affbd7ad4d163823f43cfbe51f770129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3561506 Reviewed-by:
-
- Mar 30, 2022
-
-
Adenilson Cavalcanti authored
Ported: - Cygwin does not have _wopen(), so do not create gzopen_w() there - Permit a deflateParams() parameter change as soon as possible - Limit hash table inserts after switch from stored deflate Bug: 1032721 Change-Id: Idb844aabc35e066616ee8eb018fbff1ea542ecc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3558553 Reviewed-by:
-
- Mar 29, 2022
-
-
François Degros authored
BUG=chromium:1311140 TEST=autoninja -C out/Default zlib_unittests && out/Default/zlib_unittests Change-Id: Iffd51b36fbce0bd1cdee63e8ced1ff36e59dd747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3551825 Reviewed-by:
-
- Mar 28, 2022
-
-
Hans Wennborg authored
This adds a test based on the reproducer at https://www.openwall.com/lists/oss-security/2022/03/26/1 The fix was already merged in crrev.com/583975 Bug: 1310541, 874550 Change-Id: I43ec2508a651ca3c4e962a62db8bd297a49d2da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3550971 Reviewed-by:
-
- Mar 24, 2022
-
-
François Degros authored
When reading and extracting ZIP archives, ZipReader normalizes file paths. An absolute path (starting with "/") is normalized as a relative path starting with "ROOT". Components ".." in the path are replaced with "UP". Components "." in the path are replaced with "DOT". Duplicated path separators "/" are collapsed. Characters that are not valid in Windows file names are replaced with the replacement character U+FFFD �. This replacement is done even on POSIX systems where these characters are valid. BUG=chromium:953256 TEST=autoninja -C out/Default zlib_unittests && out/Default/zlib_unittests Change-Id: I5062e0c58afaeec1b4e858eedda97e35d83316b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3538040 Reviewed-by:
-
- Mar 23, 2022
-
-
Florian Mayer authored
Upstream zlib pull request: https://github.com/madler/zlib/pull/602 Bug: 225069280 Change-Id: I548a836096323053af225083916893b851532980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3546708 Reviewed-by:
-
- Mar 21, 2022
-
-
Lei Zhang authored
Rarely would anyone ever use base/files/file_util.h functions inside a header. Most code authors meant to include base/files/file_path.h or forward declare base::FilePath. Do that and then add missing file_util.h includes to fix the build. Bug: 242216 Change-Id: I6280125f310cff0db1109c401d84e01aba386376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3518311 Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Owners-Override: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#983450} NOKEYCHECK=True GitOrigin-RevId: 527964a214baed4f325c0d7751bfc527ba10bf34
-
- Mar 18, 2022
-
-
François Degros authored
Added an option allowing the ZIP extraction to continue and try to extract as many files as possible even if some file extractions fail. BUG=chromium:953256 TEST=autoninja -C out/Default zlib_unittests && out/Default/zlib_unittests Change-Id: I2ddbfbdb3abe5d0cca3023d93fdff7fcdfc9baab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523968 Reviewed-by:
-
- Mar 17, 2022
-
-
François Degros authored
Changed the way FilePathWriterDelegate creates a new file, by using FLAG_CREATE instead of FLAG_CREATE_ALWAYS. This prevents FilePathWriterDelegate and zip::Unzip() from overwriting any existing file. This allows the detection of duplicated or conflicting file names when extracting a ZIP archive. See ZipTest.UnzipRepeatedFileName. This fixes a confusing corner case on case-insensitive file systems, which could result in file contents not matching file names as stored in the ZIP archive. See ZipTest.UnzipDifferentCases. BUG=chromium:953256 TEST=autoninja -C out/Default zlib_unittests && out/Default/zlib_unittests Change-Id: I6cf80e6d8b9e39ffc76739c00cb6f2ecf57da88f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3529591 Reviewed-by:
-
- Mar 16, 2022
-
-
François Degros authored
Added tests to zlib_unittests asserting the current behavior of zip::Unzip(): ZipTest.UnzipCannotCreateEmptyDir ZipTest.UnzipCannotCreateParentDir ZipTest.UnzipDifferentCases ZipTest.UnzipNoSuchFile ZipTest.UnzipRepeatedDirName ZipTest.UnzipRepeatedFileName ZipTest.UnzipWindowsSpecialNames BUG=chromium:953256 TEST=autoninja -C out/Default zlib_unittests && out/Default/zlib_unittests Change-Id: I26e7741083c03ffa33f820c797f78124c26f72dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3526296 Reviewed-by:
-
- Mar 14, 2022
-
-
François Degros authored
Added an OnError() method allowing a WriterDelegate to do something in case of extraction error. FileWriterDelegate::OnError() empties the output file. FilePathWriterDelegate::OnError() removes the output file altogether. BUG=chromium:1304520 TEST=autoninja -C out/Default zlib_unittests && out/Default/zlib_unittests TEST=autoninja -C out/Default components_unittests && out/Default/components_unittests --gtest_filter='UnzipTest.*' Change-Id: I3c567773a8da8c8db055db04240e646f0fc94228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3511757 Reviewed-by:
-
François Degros authored
Removed option UnzipOptions::log_skipped_files. It wasn't getting set anywhere. Instead, changed the "skipped entry" log level to VLOG(1). Improved log messages. Redacted file paths that could be considered PII in some circumstances. Changed some debug warning messages to error messages. BUG=chromium:1303983 TEST=autoninja -C out/Default zlib_unittests && out/Default/zlib_unittests TEST=autoninja -C out/Default components_unittests && out/Default/components_unittests --gtest_filter='UnzipTest.*' Change-Id: I2bc5fc7d3dcf5af465faee4bdd4311e244486a9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3520763 Reviewed-by:
-
François Degros authored
Made FilePathWriterDelegate a subclass of FileWriterDelegate. This allows to reuse code. BUG=None TEST=autoninja -C out/Default zlib_unittests && out/Default/zlib_unittests TEST=autoninja -C out/Default components_unittests && out/Default/components_unittests --gtest_filter='UnzipTest.*' Change-Id: I96bf437cddcd853850e79d820d9561cfbbd80fe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3511611 Reviewed-by:
-
François Degros authored
This allows to remove duplicated code. BUG=chromium:1303983 TEST=autoninja -C out/Default zlib_unittests && out/Default/zlib_unittests Change-Id: I4bee3b6a901122eec20eec36f0f934b841f54588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3515262 Reviewed-by:
-
François Degros authored
Removed the code that used to truncate the output file in FileWriterDelegate. There is no need for that. FileWriterDelegate is only getting passed empty files to start with. The passed file is either a freshly created one, or it is a reused temporary file that just got truncated [1]. [1] https://source.chromium.org/chromium/chromium/src/+/main:chrome/common/safe_browsing/zip_analyzer.cc;l=64;drc=e2cba64c183ae17816143ee344e6f7c81451555a BUG=None TEST=autoninja -C out/Default zlib_unittests && out/Default/zlib_unittests TEST=autoninja -C out/Default components_unittests && out/Default/components_unittests --gtest_filter='UnzipTest.*' Change-Id: Ib3551029e18d84f6e8585d8662fed9466a023207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3512049 Reviewed-by:
-
- Mar 09, 2022
-
-
François Degros authored
No functional change. Optimization only. Changed the constructor of FileWriterDelegate that takes ownership of the File. It now moves the passed File by value rather than by unique_ptr. This avoid one extra level of indirection, and dynamic memory allocation. BUG=None TEST=autoninja -C out/Default zlib_unittests && out/Default/zlib_unittests TEST=autoninja -C out/Default components_unittests && out/Default/components_unittests --gtest_filter='UnzipTest.*' Change-Id: Idca9b1836189d20fca10681fcb4d00c6d392eae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3511609 Reviewed-by:
-
- Mar 04, 2022
-
-
Daniel Cheng authored
Remaining uses are all in explicit customization points for third-party libraries, or in the case of //third_party/sudden_motion_sensor, libraries that are effectively forked. Bug: 1299695 Change-Id: Ic49e481775d76fb80efc7170bf9baa1534e7d1f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3500722 Reviewed-by:
Lei Zhang <thestig@chromium.org> Owners-Override: Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#977575} NOKEYCHECK=True GitOrigin-RevId: 05d0147c3ebf761316fa24197a6cb3de19ec1d7f
-
- Mar 01, 2022
-
-
François Degros authored
From the flakiness dashboard [1], there didn't seem to be any flakiness on the remaining ChromeOS bots that were still running this test before it got disabled. Let's try to re-enable it and monitor the situation. [1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=zlib_unittests&tests=ZipTest.BigFile This reverts commit 76d608ed096266c426e0a93ca5b8a85ab77aad72. Original change's description: > sheriff: Disable ZipTest.BigFile on CrOS due to flakiness > > Bug: 1300448 > Change-Id: I0780ceb9150f1c59cb7b801f57431b8ead6cfe7a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3489577 > Owners-Override: Yuki Shiino <yukishiino@chromium.org> > Reviewed-by:
Kentaro Hara <haraken@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/main@{#975040} Bug: 1300448, 1299736, 1298347 Change-Id: Iacd23467b70a77501bb439c49be96541a13b81f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3496442 Reviewed-by:
-
- Feb 25, 2022
-
-
Yuki Shiino authored
Bug: 1300448 Change-Id: I0780ceb9150f1c59cb7b801f57431b8ead6cfe7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3489577 Owners-Override: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
