Skip to content
Commit ecac6fd6 authored by Yohei Yukawa's avatar Yohei Yukawa
Browse files

Remove redundant enforceCallingPermission()

This CL aims to simplify security checks for

  IInputMethodManager#onShellCommand().

Basically the calling UID check [1] remains to be the main security
policy for that IPC method.  Context#enforceCallingPermission() checks
added in later CLs [2][3] are just redundant with an assumption that
the shell package has those permissions.

For simplicity and readability, let's keep only the most relevant
security check for IMMS#onShellCommand() method.

 [1]: If87189563ccaacd4f9c666bab4f9ad08a9343084
      b8d240fa
 [2]: I6fd47b5cc1e7da7222774df20247a2c69a70f45b
      db25df71
 [3]: If91137e0c144d90ac3046f30607e36bb957a7e0e
      8a2b96bb

Bug: 34886274
Test: atest CtsInputMethodServiceHostTestCases:ShellCommandFromAppTest
Change-Id: I19a6833bb7ff6100d4e9428243005377a7fbf432
parent 0ac31bf6
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment