Skip to content
Commit ec0dad20 authored by Christian Göllner's avatar Christian Göllner
Browse files

Fix QS and QS Footer sometimes having low alpha after expansion

This could happen in two cases:
- Fast fling to expand shade
- Setting global animator duration scale to 0

There were two issues in the code:
- For the footer: During very fast flings, QSFragment was receiving
  calls to setExpansion, and when certain parameters where the same as
  before, there was an early return, and the footer alpha was not being
  set. The code to check if the parameters were the same as before,
  forgot to check for the value of "panelExpansionFraction". This was
  different than before, and used for the footer alpha, but ignored in
  the check.
- For the entire panel: reproducible when setting animator duration
  scale to 0.
  The issue was that QuickSettingsController didn't have the most up to
  date value for the shade expansion fraction.
  When animator duration scale was 1, this issue was almost no visible
  because it keep getting new values until reaching 0.999 of expansion.
  When setting the animator duration scale to 0, there will only be one
  call with the updated expansion, instead of multiple, so the out of
  date value will be noticeable.

Fixes: 271605496
Fixes: 219589379
Test: Manually, as described above.
Change-Id: I4ab954b1d5ccca609af63179e72e053f7e1f4a64
parent 4626fa48
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment