Skip to content
Commit 90d8bcf8 authored by Winson Chung's avatar Winson Chung
Browse files

Fix a couple issues with nav bar & rotation button

- Ensure that newly added buttons to the contextual group are not
  visible by default, this can cause issues where they are clickable
  if setButtonVisibility() is not called to ensure only one button
  is visible
- Fix an issue where the rotation controller and context group buttons
  were not updated on nav mode change (leading to floating rotation
  button w/ 3 button nav and rotation context button w/ gestural nav).
  This is a regression in S due to us not reinflating the entire nav
  bar view on nav mode change.
- Move ime switcher handling to NavBar to be consistent with other
  contextual buttons
- Prevent reloading nav bar multiple times on nav mode change

Fixes: 183475747
Test: Change nav modes and dump the context buttons to verify they
      are updated correctly
Change-Id: I01779af237a46909f04fe76d74dd552af8a034e4
parent e8b84a6e
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment