Skip to content
Commit 7dec49e7 authored by Alec Mouri's avatar Alec Mouri
Browse files

Remove vkDeviceWaitIdle call when destroying VulkanSurface

vkDeviceWaitIdle requires external synchronization of all queues created from the VkDevice, which would mean that we would need to add locking to the AHB uploader queue for this to be thread-safe.

However, we should not need to wait for queue submissions for the AHB uploader at all for destroying the output surface, because the AHB uploader queue is meant for swizzling bitmaps - there's no dependency on the output surface.

So, it is just sufficient to wait on submission of the graphics queue, which is currently thread-safe as all graphics queue operations occur only on renderthread.

Bug: 288201932
Change-Id: Ia3ca1600f22941d9900b2e5451f7572a79abf049
Test: builds
Test: com.android.launcher3.ui.TaplTestsLauncher3#testDragShortcutToWorkspaceCell 99 times
parent 057c1e7c
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment