Disable dtor inlining for clang-tidy
LLVM r328258 turned on a feature called temporary dtor inlining by default for all of C++ in clang-tidy. This feature appears to be somewhat over-aggressive when objects are being passed by value. For example, given: void foo(std::unique_ptr<int> i); void bar() { auto x = std::make_unique<int>(); int *i = x.get(); foo(std::move(x)); *i = 99; } ...clang-tidy will complain about `*i = 99;` being a definite use-after-free. This is incorrect, however: `foo` could stash the `unique_ptr` it's given in a global, or a class member, or ... Until upstream fixes this bug, it's probably best to keep this disabled. Bug: None Test: Ran the analyzer across Android locally. Nothing broke; number of complaints dropped significantly. Change-Id: I806c7ead34b61f4a88a7e6ec1c94751836a21e70
Loading
Please register or sign in to comment